Add formatter pyproject regression coverage by koxudaxi · Pull Request #596 · koxudaxi/fastapi-code-generator

koxudaxi · 2026-05-31T14:16:26Z

Summary by CodeRabbit

Documentation
- Updated supported input formats documentation to reflect additional OpenAPI YAML fixture coverage.
Tests
- Added test coverage for OpenAPI formatter configuration with parent project settings.

coderabbitai · 2026-05-31T14:16:33Z

Warning

Review limit reached

@koxudaxi, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 11 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c0a8dc13-8e38-45f4-a3eb-93ce6bf61302

📥 Commits

Reviewing files that changed from the base of the PR and between 811ca43 and b35b00f.

📒 Files selected for processing (5)

docs/llms-full.txt
docs/supported_formats.md
fastapi_code_generator/prompt_data.py
tests/data/expected/openapi/coverage/request_body_without_schema/main.py
tests/main/test_main.py

Walkthrough

This PR adds a new OpenAPI code generation test fixture that validates handling of projects where pyproject.toml resides in a parent directory. It includes the input OpenAPI specification, expected generated Python code, a test case that validates the generation process, and documentation updates reflecting the new fixture.

Changes

OpenAPI formatter_parent_pyproject test fixture

Layer / File(s)	Summary
Input fixture - OpenAPI spec and configuration `tests/data/openapi/coverage/formatter_parent_pyproject/api.yaml`, `tests/data/openapi/coverage/formatter_parent_pyproject/pyproject.toml`	OpenAPI 3.0 YAML specification defines a `/pets` GET endpoint with Pet and Pets schemas; Poetry configuration specifies project metadata.
Expected generated output `tests/data/expected/openapi/coverage/formatter_parent_pyproject/models.py`, `tests/data/expected/openapi/coverage/formatter_parent_pyproject/main.py`	Generated `Pet` Pydantic model with `id` and `name` fields, and FastAPI application with configured metadata and `/pets` endpoint handler returning `List[Pet]`.
Test validation `tests/main/test_main.py`	New test copies fixture files into a temporary project, runs the code generator with timestamp disabled, and validates output matches the expected generated code.
Documentation update `docs/supported_formats.md`	OpenAPI YAML fixture count updated from 28 to 29.

🎯 2 (Simple) | ⏱️ ~12 minutes

🐰 A test fixture hops into the garden,
With pets and schemas, we beg your pardon!
The spec, expected, and test align,
One fuzzy checkpoint, a change so fine! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: adding regression coverage for formatter pyproject settings, which is reflected in the new test and fixture files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch add-black-formatter-regression

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed · 2026-05-31T14:19:42Z

Merging this PR will not alter performance

⚠️

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 1 untouched benchmark

_{Comparing add-black-formatter-regression (b35b00f) with main (3bf3c02)}

github-actions · 2026-05-31T14:21:35Z

📚 Docs Preview: https://pr-596.fastapi-code-generator.pages.dev

codecov · 2026-05-31T14:41:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fa1e00e) to head (b35b00f).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #596   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1375      1404   +29     
  Branches       140       143    +3     
=========================================
+ Hits          1375      1404   +29

Flag	Coverage Δ
unittests	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-05-31T15:31:59Z

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: PR #596 only adds new test coverage (a regression test for formatter configuration with parent pyproject.toml) and updates documentation fixture counts. No production source code (CLI, parser, config, templates, or code generation logic) was modified. The only non-test change is updating fixture counts in docs. This is purely additive test infrastructure with no impact on users.

This analysis was performed by Claude Code Action

github-actions · 2026-05-31T15:53:58Z

🎉 Released in 0.7.0

This PR is now available in the latest release. See the release notes for details.

Add formatter pyproject regression coverage

1e0ad45

koxudaxi added 2 commits May 31, 2026 14:24

Move formatter regression to fixtures

811ca43

Update generated prompt docs

14fb215

koxudaxi marked this pull request as ready for review May 31, 2026 14:56

koxudaxi added 3 commits May 31, 2026 15:01

Merge main into formatter coverage

4e94fcd

Merge main into formatter coverage

ea0f245

Merge main into formatter coverage

b35b00f

koxudaxi merged commit 6132045 into main May 31, 2026
46 checks passed

koxudaxi deleted the add-black-formatter-regression branch May 31, 2026 15:30

github-actions Bot added the breaking-change-analyzed PR has been checked for release draft updates label May 31, 2026

koxudaxi mentioned this pull request May 31, 2026

TypeError: Mode.__init__() got an unexpected keyword argument 'experimental_string_processing' #406

Closed

Navigation Menu

Repository navigation

Add formatter pyproject regression coverage - #596

Add formatter pyproject regression coverage#596
koxudaxi merged 6 commits into
mainfrom
add-black-formatter-regression

koxudaxi commented May 31, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 31, 2026 •

edited

Loading

Review limit reached

❌ Failed checks (1 warning)

Uh oh!

codspeed Bot commented May 31, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 31, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented May 31, 2026

Uh oh!

github-actions Bot commented May 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

koxudaxi commented May 31, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

codspeed Bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

github-actions Bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions Bot commented May 31, 2026

Breaking Change Analysis

Uh oh!

github-actions Bot commented May 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

koxudaxi commented May 31, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 31, 2026 •

edited

Loading

codspeed Bot commented May 31, 2026 •

edited

Loading

github-actions Bot commented May 31, 2026 •

edited

Loading

codecov Bot commented May 31, 2026 •

edited

Loading